group.cc

Go to the documentation of this file.

/*
  @copyright Steve Keen 2015
  @author Russell Standish
  This file is part of Minsky.

  Minsky is free software: you can redistribute it and/or modify it
  under the terms of the GNU General Public License as published by
  the Free Software Foundation, either version 3 of the License, or
  (at your option) any later version.

  Minsky is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU General Public License for more details.

  You should have received a copy of the GNU General Public License
  along with Minsky.  If not, see <http://www.gnu.org/licenses/>.
*/

#include "minsky.h"
#include "cairoItems.h"
#include "group.h"
#include "wire.h"
#include "operation.h"
#include "autoLayout.h"
#include "equations.h"
#include <cairo_base.h>
#include "group.rcd"
#include "itemT.rcd"
#include "bookmark.rcd"
#include "progress.h"
#include "minsky_epilogue.h"
using namespace std;
using namespace ecolab::cairo;

// size of the top and bottom margins of the group icon
static const int topMargin=10;

namespace minsky
{
  SVGRenderer Group::svgRenderer;

  namespace
  {
    // return true if scope g refers to the global model group
    bool isGlobal(const GroupPtr& g)
    {return !g || g==cminsky().model;}
  }
  
  double Group::operator()(const std::vector<double>& p) 
  {
    if (outVariables.empty()) return nan("");

    MathDAG::SystemOfEquations system(minsky(), *this);
    EvalOpVector equations;
    vector<Integral> integrals;
    system.populateEvalOpVector(equations, integrals);
    auto flow(ValueVector::flowVars);

    // assign values to unattached input variables
    auto iVar=inVariables.begin();
    for (auto v: p)
      {
        while (iVar!=inVariables.end() && (*iVar)->inputWired()) ++iVar;
        if (iVar==inVariables.end()) break;
        flow[(*iVar)->vValue()->idx()]=v;
      }

    for (auto& i: equations)
      i->eval(flow.data(), flow.size(),ValueVector::stockVars.data());
    return flow[outVariables[0]->vValue()->idx()];
  }

  std::string Group::formula() const
  {
    if (outVariables.empty()) return "0";
    MathDAG::SystemOfEquations system(minsky(), *this);
    ostringstream o;
    auto node=system.getNodeFromVar(*outVariables[0]);
    if (!node) return "0";
    if (node->rhs)
      node->rhs->matlab(o);
    else
      node->matlab(o);
    return o.str();
  }

  string Group::arguments() const
  {
    MathDAG::SystemOfEquations system(minsky(), *this);
    ostringstream r;
    r<<"(";
    for (auto& i: inVariables)
      if (!i->inputWired())
        {
          if (r.str().size()>1) r<<",";
          if (auto node=system.getNodeFromVar(*i))
            node->matlab(r);
        }
    r<<")";
    return r.str();
  }

  
  // assigned the cloned equivalent of a port
  void asgClonedPort(shared_ptr<Port>& p, const map<Item*,ItemPtr>& cloneMap)
  {
    auto clone=cloneMap.find(&p->item());
    if (clone!=cloneMap.end())
      {
        for (size_t i=0; i<p->item().portsSize(); ++i)
          if (p->item().ports(i).lock()==p)
            {
              // set the new port to have the equivalent position in the clone
              p=clone->second->ports(i).lock();
              assert(p);
            }
      }
  }

  GroupPtr Group::copy() const
  {
    // make new group owned by the top level group to prevent
    if (auto g=group.lock())
      return g->addGroup(copyUnowned());
    return GroupPtr(); // do nothing if we attempt to clone the entire model
  }
  
  GroupPtr Group::copyUnowned() const
  {
    auto r=make_shared<Group>();
    r->self=r;
    r->moveTo(x(),y());
    // make new group owned by the top level group to prevent snarlups when called recursively
    if (group.lock())
      const_cast<Group*>(this)->globalGroup().addGroup(r);
    else
      return GroupPtr(); // do nothing if we attempt to clone the entire model
  
    // a map of original to cloned items (weak references)
    map<Item*,ItemPtr> cloneMap;
    map<IntOp*,bool> integrals;
    // cloning IntOps mutates items, as intVars get inserted and removed
    auto itemsCopy=items;
    for (auto& i: itemsCopy)
      if (auto integ=dynamic_cast<IntOp*>(i.get()))
        integrals.emplace(integ, integ->coupled());
    for (auto& i: itemsCopy)
      cloneMap[i.get()]=r->addItem(i->clone(),true);
    for (auto& i: groups)
      cloneMap[i.get()]=r->addGroup(i->copyUnowned());
    for (auto& w: wires) 
      {
        auto f=w->from(), t=w->to();
        asgClonedPort(f,cloneMap);
        asgClonedPort(t,cloneMap);
        r->addWire(new Wire(f,t,w->coords()));
      }
  
    for (auto& v: inVariables)
      {
        assert(cloneMap.count(v.get()));
        r->inVariables.push_back(dynamic_pointer_cast<VariableBase>(cloneMap[v.get()]));
        r->inVariables.back()->controller=self;
      }
    for (auto& v: outVariables)
      {
        assert(cloneMap.count(v.get()));
        r->outVariables.push_back(dynamic_pointer_cast<VariableBase>(cloneMap[v.get()]));
        r->outVariables.back()->controller=self;
      }
    // reattach integral variables to their cloned counterparts
    for (auto i: integrals)
      {
        if (auto newIntegral=dynamic_cast<IntOp*>(cloneMap[i.first].get()))
          {
            auto newIntVar=dynamic_pointer_cast<VariableBase>(cloneMap[i.first->intVar.get()]);
            if (newIntVar && newIntegral->intVar != newIntVar)
              {
                r->removeItem(*newIntegral->intVar);
                newIntegral->intVar=newIntVar;
              }
            if (i.second != newIntegral->coupled())
              newIntegral->toggleCoupled();
          }
      }
    r->computeRelZoom();
    return r;
  }

  void Group::makeSubroutine()
  {
    recursiveDo(&GroupItems::items, [this](Items&,Items::iterator i)
    {
      if (auto v=(*i)->variableCast())
        if (v->rawName()[0]==':')
          {
            // walk up parent groups to see if this variable is mentioned
            for (auto g=group.lock(); g; g=g->group.lock())
              for (auto& item: g->items)
                if (auto vi=item->variableCast())
                  if (vi->valueId()==v->valueId())
                    goto outer_scope_variable_found;
            v->name(v->rawName().substr(1)); // make variable local
          }
    outer_scope_variable_found:
      return false;
    });
  }

  
  ItemPtr GroupItems::removeItem(const Item& it)
  {
    if (it.plotWidgetCast()==displayPlot.get()) removeDisplayPlot();
    if (!inDestructor) bookmarks.erase(it.bookmarkId());
    for (auto i=items.begin(); i!=items.end(); ++i)
      if (i->get()==&it)
        {
          ItemPtr r=*i;
          items.erase(i);
          if (auto v=r->variableCast())
              if (v->ioVar())
                {
                 remove(inVariables, r);
                 remove(outVariables, r);
                 remove(createdIOvariables, r);
                 v->controller.reset();
                }
          return r;
        }

    for (auto i=groups.begin(); i!=groups.end(); ++i)
      if (i->get()==&it)
        {
          ItemPtr r=*i;
          groups.erase(i);
          return r;
        }
    
    
    for (auto& g: groups)
      if (ItemPtr r=g->removeItem(it))
        return r;
    return ItemPtr();
  }

  void Group::deleteItem(const Item& i)
  {
    if (auto r=removeItem(i))
      {
        r->deleteAttachedWires();
        r->removeControlledItems();
        minsky().runItemDeletedCallback(*r);
        minsky().bookmarkRefresh();
      }
  }

  
  WirePtr GroupItems::removeWire(const Wire& w)
  {
    for (auto i=wires.begin(); i!=wires.end(); ++i)
      if (i->get()==&w)
        {
          WirePtr r=*i;
          wires.erase(i);
          return r;
        }

    for (auto& g: groups)
      if (WirePtr r=g->removeWire(w))
        return r;
    return WirePtr();
  }

  GroupPtr GroupItems::removeGroup(const Group& group)
  {
    for (auto i=groups.begin(); i!=groups.end(); ++i)
      if (i->get()==&group)
        {
          GroupPtr r=*i;
          groups.erase(i);
          return r;
        }

    for (auto& g: groups)
      if (GroupPtr r=g->removeGroup(group))
        return r;
    return GroupPtr();
  }
       
  ItemPtr GroupItems::findItem(const Item& it) const 
  {
    // start by looking in the group it thnks it belongs to
    if (auto g=it.group.lock())
      if (g.get()!=this) 
        {
          auto i=g->findItem(it);
          if (i) return i;
        }
    return findAny(&Group::items, [&](const ItemPtr& x){return x.get()==&it;});
  }

  void GroupItems::renameVar(const GroupPtr& origGroup, VariableBase& v)
  {
    if (auto thisGroup=self.lock())
      {
        if (origGroup->higher(*thisGroup))
          {
            // moving local var into an inner group, make global
            if (v.rawName()[0]!=':')
              v.name(':'+v.rawName());
          }
        else if (thisGroup->higher(*origGroup))
          {
            // moving global var into an outer group, link up with variable of same name (if existing)
            if (v.name()[0]==':')
              for (auto& i: items)
                if (auto vv=i->variableCast())
                  if (vv->name()==v.name().substr(1))
                    v.name(v.name().substr(1));
          }
        else
          // moving between unrelated groups
          if (v.name()[0]==':' && valueId(thisGroup,v.name()) != valueId(origGroup,v.name()))
            // maintain linkage if possible, otherwise make local
            v.name(v.name().substr(1));
      }
  }

  
  ItemPtr GroupItems::addItem(const shared_ptr<Item>& it, bool inSchema)
  {
    if (!it) return it;
    minsky().bookmarkRefresh();
    if (auto x=dynamic_pointer_cast<Group>(it))
      return addGroup(x);
   
    // stash position
    const float x=it->x(), y=it->y();
    auto origGroup=it->group.lock();

    if (origGroup.get()==this) return it; // nothing to do.
    if (origGroup)
      origGroup->removeItem(*it);

    // stash init value to initialise new variableValue
    string init;
    string units;
    if (auto v=it->variableCast())
      {
        init=v->init();
        units=v->unitsStr();
      }
    
    it->group=self;
    if (!inSchema) it->moveTo(x,y);

    // take into account new scope
    if (auto v=it->variableCast())
      {
        if (!inSchema && origGroup)
          renameVar(origGroup, *v);
        v->init(init); //NB calls ensureValueExists()
        // if value didn't exist before, units will be empty. Do not overwrite any previous units set. For #1461.
        if (units.length()) v->setUnits(units);
      }
     
    // move wire to highest common group
    for (size_t i=0; i<it->portsSize(); ++i)
      {
        auto p=it->ports(i).lock();
        assert(p);
        for (auto& w: p->wires())
          {
            assert(w);
            adjustWiresGroup(*w);
          }
      }

    // need to deal with integrals especially because of the attached variable
    if (auto intOp=dynamic_cast<IntOp*>(it.get()))
      if (intOp->intVar)
        {
          if (!inSchema && origGroup)
            renameVar(origGroup, *intOp->intVar);
          if (auto oldG=intOp->intVar->group.lock())
           {
                 
             if (oldG.get()!=this)
               addItem(oldG->removeItem(*intOp->intVar),inSchema);
           }
          else
            addItem(intOp->intVar,inSchema);
          if (intOp->coupled())
            intOp->intVar->controller=it;
          else
            intOp->intVar->controller.reset();
        }
         
    items.push_back(it);
    return items.back();
  }

  void GroupItems::adjustWiresGroup(Wire& w)
  {
    // Find common ancestor group, and move wire to it
    assert(w.from() && w.to());
    shared_ptr<Group> p1=w.from()->item().group.lock(), p2=w.to()->item().group.lock();
    assert(p1 && p2);
    unsigned l1=p1->level(), l2=p2->level();
    for (; p1 && l1>l2; l1--) p1=p1->group.lock();
    for (; p2 && l2>l1; l2--) p2=p2->group.lock();
    
    while (p1 && p2 && p1!=p2) 
      {
        assert(p1 && p2);
        p1=p1->group.lock();
        p2=p2->group.lock();
      }
    if (!p1 || !p2) return;
    w.moveIntoGroup(*p1);
  }
  
  void Group::splitBoundaryCrossingWires()
  {
    // Wire::split will invalidate the Items::iterator, so collect
    // wires to split first
    set<Wire*> wiresToSplit;
    for (auto& i: items)
      for (size_t p=0; p<i->portsSize(); ++p)
        for (auto w: i->ports(p).lock()->wires())
          wiresToSplit.insert(w);

    for (auto w: wiresToSplit)
      w->split();

    // check if any created I/O variables can be removed
    auto varsToCheck=createdIOvariables;
    for (auto& iv: varsToCheck)
      {
        assert(iv->ports(1).lock()->input() && !iv->ports(1).lock()->multiWireAllowed());
        // firstly join wires that don't cross boundaries
        // determine if this is input or output var
        if (!iv->ports(1).lock()->wires().empty())
          {
            auto fromGroup=iv->ports(1).lock()->wires()[0]->from()->item().group.lock();
            if (fromGroup.get() == this)
              {
                // not an input var
                for (auto& w: iv->ports(0).lock()->wires())
                  if (w->to()->item().group.lock().get() == this)
                    // join wires, as not crossing boundary
                    {
                      auto to=w->to();
                      iv->ports(0).lock()->eraseWire(w);
                      removeWire(*w);
                      addWire(iv->ports(1).lock()->wires()[0]->from(), to);
                    }
              }
            else
              for (auto& w: iv->ports(0).lock()->wires())
                if (w->to()->item().group.lock() == fromGroup)
                  // join wires, as not crossing boundary
                  {
                    auto to=w->to();
                    iv->ports(0).lock()->eraseWire(w);
                    globalGroup().removeWire(*w);
                    adjustWiresGroup(*addWire(iv->ports(1).lock()->wires()[0]->from(), to));
                  }
          }
        
        if (iv->ports(0).lock()->wires().empty() || iv->ports(1).lock()->wires().empty())
          removeItem(*iv);
      }
  }

  size_t GroupItems::numItems() const
  {
    size_t count=items.size();
    for (auto& i: groups) count+=i->numItems();
    return count;
  }

  size_t GroupItems::numWires() const
  {
    size_t count=wires.size();
    for (auto& i: groups) count+=i->numWires();
    return count;
  }

  size_t GroupItems::numGroups() const
  {
    size_t count=groups.size();
    for (auto& i: groups) count+=i->numGroups();
    return count;
  }


  void Group::moveContents(Group& source) {
     if (&source!=this)
       {
         if (source.higher(*this))
             throw error("attempt to move a group into itself");
         // make temporary copies as addItem removes originals
         auto copyOfItems=source.items;
         for (auto& i: copyOfItems)
           {
             addItem(i);
             assert(!i->ioVar());
           }
         auto copyOfGroups=source.groups;
         for (auto& i: copyOfGroups)
           addGroup(i);
         source.clear();
       }
  }

  VariablePtr Group::addIOVar(const char* prefix)
  {
    const VariablePtr v(VariableType::flow,
                  uqName(cminsky().variableValues.newName(to_string(size_t(this))+":"+prefix)));
    addItem(v,true);
    createdIOvariables.push_back(v);
    v->rotation(rotation());
    v->controller=self;
    bb.update(*this);
    return v;
  }
  
  Group::IORegion::type Group::inIORegion(float x, float y) const
  {
    float left, right;
    const float z=zoomFactor();
    margins(left,right);    
    const float dx=(x-this->x())*cos(rotation()*M_PI/180)-
      (y-this->y())*sin(rotation()*M_PI/180);
    const float dy=(x-this->x())*sin(rotation()*M_PI/180)+
      (y-this->y())*cos(rotation()*M_PI/180);      
    const float w=0.5*iWidth()*z,h=0.5*iHeight()*z;
    if (w-right<dx)
      return IORegion::output;
    if (-w+left>dx)
      return IORegion::input;
    if ((-h+topMargin*z>dy && dy<0) || (h-topMargin*z<dy && dy>0))     
      return IORegion::topBottom;  
    return IORegion::none;
  }

  void Group::checkAddIORegion(const ItemPtr& x)
  {
    if (auto v=dynamic_pointer_cast<VariableBase>(x))
      {
        remove(inVariables, v);
        remove(outVariables, v);
        switch (inIORegion(v->x(),v->y()))
          {
          case IORegion::input:
            inVariables.push_back(v);
            v->controller=self;
            break;
          case IORegion::output:
            outVariables.push_back(v);
            v->controller=self;
            break;
          default:
            v->controller.reset();
            break;
          }
      }
  }

  
  void Group::resizeOnContents()
  {
    double x0, x1, y0, y1;
    contentBounds(x0,y0,x1,y1);
    const double xx=0.5*(x0+x1), yy=0.5*(y0+y1);
    const double dx=xx-x(), dy=yy-y();
    float l,r; margins(l,r);    
    const float z=zoomFactor();
    m_width=((x1-x0)+l+r)/z;
    m_height=((y1-y0)+20*z)/z;

    // adjust contents by the offset
    for (auto& i: items)
      i->moveTo(i->x()-dx, i->y()-dy);
    for (auto& i: groups)
      i->moveTo(i->x()-dx, i->y()-dy);

    moveTo(xx,yy);
    bb.update(*this);
  }

  namespace
  {
    template <class T>
    void resizeItems(T& items, double sx, double sy)
    {
      for (auto& i: items)
        if (!i->ioVar())
          {
            i->m_x*=sx;
            i->m_y*=sy;
          }
    }

    
    
    template <class T>
    void recentreItems(const T& items, float xc, float yc)
    {
      for (auto& i: items)
        if (!i->ioVar())
          {
            i->m_x-=xc;
            i->m_y-=yc;
          }
    }

  
  }
  
  void Group::resize(const LassoBox& b)
  {
    float z=zoomFactor();
    // account for margins
    float l, r;
    margins(l,r);
    if (fabs(b.x0-b.x1) < l+r || fabs(b.y0-b.y1)<2*z*topMargin) return;
    iWidth(fabs(b.x0-b.x1)/z);
    iHeight((fabs(b.y0-b.y1)-2*topMargin)/z);
    // TODO - it is wasteful to call contentBounds within computeRelZoom, then again a few lines later
    computeRelZoom(); // needed to ensure grouped items scale properly with resize operation. for ticket 1243    
    z=zoomFactor();     // recalculate zoomFactor because relZoom changed above. for ticket 1243
    double x0, x1, y0, y1;
    contentBounds(x0,y0,x1,y1);
    recentreItems(items,0.5*(x0+x1)-x(),0.5*(y0+y1)-y());
    recentreItems(groups,0.5*(x0+x1)-x(),0.5*(y0+y1)-y());
    double sx=(fabs(b.x0-b.x1)-z*(l+r))/(x1-x0), sy=(fabs(b.y0-b.y1)-2*z*topMargin)/(y1-y0);
    sx=std::min(sx,sy);
    resizeItems(items,sx,sx);
    resizeItems(groups,sx,sx);
    
    moveTo(0.5*(b.x0+b.x1), 0.5*(b.y0+b.y1));
    bb.update(*this);
  }
  
  bool Group::nocycles() const
  {
    set<const Group*> sg;
    sg.insert(this);
    for (auto i=group.lock(); i; i=i->group.lock())
      if (!sg.insert(i.get()).second)
        return false;
    return true;
  }

  GroupPtr GroupItems::addGroup(const std::shared_ptr<Group>& g)
  {
    assert(g);
    auto origGroup=g->group.lock();
    if (origGroup.get()==this) return g; // nothing to do
    if (origGroup)
      origGroup->removeGroup(*g);
    groups.push_back(g);
    g->group=self;
    g->self=groups.back();
    assert(nocycles());
    return groups.back();
  }

  WirePtr GroupItems::addWire(const std::shared_ptr<Wire>& w)
  {
    assert(w->from() && w->to());
    wires.push_back(w);
    return wires.back();
  }
  WirePtr GroupItems::addWire
  (const weak_ptr<Port>& fromPw, const weak_ptr<Port>& toPw, const vector<float>& coords)
  {
    auto fromP=fromPw.lock(), toP=toPw.lock();
    // disallow self-wiring
    if (!fromP || !toP || &fromP->item()==&toP->item()) 
      return WirePtr();

    // wire must go from an output port to an input port
    if (fromP->input() || !toP->input())
      return WirePtr();

    // check that multiple input wires are only to binary ops.
    if (!toP->wires().empty() && !toP->multiWireAllowed())
      return WirePtr();

    // check that a wire doesn't already exist connecting these two ports
    for (auto& w: toP->wires())
      if (w->from()==fromP)
        return WirePtr();

    // disallow wiring the input of an already defined variable
    if (auto v=toP->item().variableCast())
      if (cminsky().inputWired(v->valueId()))
        return {};
    
    auto w=addWire(new Wire(fromP, toP, coords));
    adjustWiresGroup(*w);

    return w;
  }


  bool Group::higher(const Group& x) const
  {
    for (auto& i: groups)
      if (i.get()==&x) return true;
    return any_of(groups.begin(), groups.end(), [&](const GroupPtr& i){return i->higher(x);});
  }

  unsigned Group::level() const
  {
    assert(nocycles());
    unsigned l=0;
    for (auto i=group.lock(); i; i=i->group.lock()) l++;
    return l;
  }

  namespace
  {
    template <class G>
    G& globalGroup(G& start)
    {
      auto g=&start;
      for (auto i=start.group.lock(); i; i=i->group.lock())
        g=i.get();
      return *g;
    }
  }

  const Group& Group::globalGroup() const
  {return minsky::globalGroup(*this);}
  Group& Group::globalGroup()
  {return minsky::globalGroup(*this);}



  
  bool Group::uniqueItems(set<void*>& idset) const
  {
    for (auto& i: items)
      if (!idset.insert(i.get()).second) return false;
    for (auto& i: wires)
      if (!idset.insert(i.get()).second) return false;
    for (auto& i: groups)
      if (!idset.insert(i.get()).second || !i->uniqueItems(idset)) 
        return false;
    return true;
  }

  float Group::contentBounds(double& x0, double& y0, double& x1, double& y1) const
  {
    const float localZoom=1;
    x0=numeric_limits<float>::max();
    x1=-numeric_limits<float>::max();
    y0=numeric_limits<float>::max();
    y1=-numeric_limits<float>::max();

    for (auto& i: items)
      if (!i->ioVar())
        {
          if (i->left()<x0) x0=i->left();
          if (i->right()>x1) x1=i->right();
          if (i->top()<y0) y0=i->top();
          if (i->bottom()>y1) y1=i->bottom();
        }               
                          
    for (auto& i: groups)
      if (i->displayContents())
        {
          double left, top, right, bottom;
          i->contentBounds(left,top,right,bottom);
          if (left<x0) x0=left;
          if (right>x1) x1=right;
          if (top<y0) y0=top;
          if (bottom>y1) y1=bottom;
        }
      else
        {
          if (i->left()<x0) x0=i->left();
          if (i->right()>x1) x1=i->right();
          if (i->top()<y0) y0=i->top();
          if (i->bottom()>y1) y1=i->bottom();
        }
   
    // if there are no contents, result is not finite. In this case,
    // set the content bounds to a 10x10 sized box around the centroid of the I/O variables.
    if (x0==numeric_limits<float>::max())
      {
        float cx=0, cy=0;
        for (auto& i: inVariables)
          {
            cx+=i->x();
            cy+=i->y();
          }
        for (auto& i: outVariables)
          {
            cx+=i->x();
            cy+=i->y();
          }
        const int n=inVariables.size()+outVariables.size();
        if (n>0)
          {
            cx/=n;
            cy/=n;
          }
        x0=cx-10;
        x1=cx+10;
        y0=cy-10;
        y1=cy+10;
      }

    return localZoom;
  }

  float Group::computeDisplayZoom()
  {
    double x0, x1, y0, y1;
    const float z=zoomFactor();    
    const float lz=contentBounds(x0,y0,x1,y1);
    x0=min(x0,double(x()));
    x1=max(x1,double(x()));
    y0=min(y0,double(y()));
    y1=max(y1,double(y()));
    // first compute the value assuming margins are of zero width
    displayZoom = 2*max( max(x1-x(), x()-x0)/(iWidth()*z), max(y1-y(), y()-y0)/(iHeight()*z));

    // account for shrinking margins
    const float readjust=zoomFactor()/edgeScale() / (displayZoom>1? displayZoom:1);
    float l, r;    
    margins(l,r);
    l*=readjust; r*=readjust;    
    displayZoom = max(displayZoom, 
                  float(max((x1-x())/(0.5f*iWidth()*z-r), (x()-x0)/(0.5f*iWidth()*z-l))));
  
    displayZoom*=1.1*rotFactor()/lz;

    // displayZoom should never be less than 1
    displayZoom=max(displayZoom, 1.0f);
    return displayZoom;
  }

  void Group::computeRelZoom()
  {
    double x0, x1, y0, y1;
    const double z=zoomFactor();
    relZoom=1;
    contentBounds(x0,y0,x1,y1);
    float l, r;
    margins(l,r);    
    const double dx=x1-x0, dy=y1-y0;
    if (width()-l-r>0 && dx>0 && dy>0)
      relZoom=std::min(1.0, std::min((width()-l-r)/(dx), (height()-20*z)/(dy))); 
  }
  
  const Group* Group::minimalEnclosingGroup(float x0, float y0, float x1, float y1, const Item* ignore) const
  {
    const float z=zoomFactor();
    if (x0<x()-0.5*z*iWidth() || x1>x()+0.5*z*iWidth() ||
        y0<y()-0.5*z*iHeight() || y1>y()+0.5*z*iHeight())
      return nullptr;
    // at this point, this is a candidate. Check if any child groups are also
    for (auto& g: groups)
      if (auto mg=g->minimalEnclosingGroup(x0,y0,x1,y1, ignore))
        if (mg->visible())
          return mg;
    return this!=ignore? this: nullptr;
  }

  void Group::setZoom(float factor)
  {
    const bool dpc=displayContents();
    if (!group.lock())
      relZoom=factor;
    else
      computeRelZoom();
    const float lzoom=localZoom();
    m_displayContentsChanged = dpc!=displayContents();
    for (auto& i: groups)
      {
        i->setZoom(lzoom);
        m_displayContentsChanged|=i->displayContentsChanged();
      }
  }

  void Group::zoom(float xOrigin, float yOrigin,float factor)
  {
    const bool dpc=displayContents();
    minsky::zoom(m_x,xOrigin+m_x-x(),factor);
    minsky::zoom(m_y,yOrigin+m_y-y(),factor);
    m_displayContentsChanged = dpc!=displayContents();
    if (!group.lock())
      relZoom*=factor;
    for (auto& i: groups)
      {
        if (displayContents() && !m_displayContentsChanged)
          i->zoom(i->x(), i->y(), factor);
        m_displayContentsChanged|=i->displayContentsChanged();
      }
  }

  ClickType::Type Group::clickType(float x, float y) const
  {
    auto z=zoomFactor();
    const double w=0.5*iWidth()*z, h=0.5*iHeight()*z;
    if (onResizeHandle(x,y)) return ClickType::onResize;         
    if (displayContents() && inIORegion(x,y)==IORegion::none)
      return ClickType::outside;
    if (auto item=select(x,y))
      return item->clickType(x,y);
    if ((abs(x-this->x())<w && abs(y-this->y())<h+topMargin*z)) // check also if (x,y) is within top and bottom margins of group. for feature 88
      return ClickType::onItem;
    return ClickType::outside;
  }

  void Group::draw(cairo_t* cairo) const
  {
    auto [angle,flipped]=rotationAsRadians();

    // determine how big the group icon should be to allow
    // sufficient space around the side for the edge variables
    float leftMargin, rightMargin;
    margins(leftMargin, rightMargin);    
    const float z=zoomFactor();

    const unsigned width=z*this->iWidth(), height=z*this->iHeight();
    const cairo::CairoSave cs(cairo);
    cairo_rotate(cairo,angle);

    // In docker environments, something invisible gets drawn outside
    // the horizontal dimensions, stuffing up the bb.width()
    // calculation, and then causing the groupResize test to
    // fail. This extra clip path fixes the problem.
    cairo_rectangle(cairo,-0.5*width,-0.5*height-topMargin*z, width, height+2*topMargin*z);
    cairo_clip(cairo);

    // draw default group icon

    // display I/O region in grey
    drawIORegion(cairo);

    {
      const cairo::CairoSave cs(cairo);
      cairo_translate(cairo, -0.5*width+leftMargin, -0.5*height);

              
      const double scalex=double(width-leftMargin-rightMargin)/width;
      cairo_scale(cairo, scalex, 1);
      
      // draw a simple frame 
      cairo_rectangle(cairo,0,0,width,height);
      {
        const cairo::CairoSave cs(cairo);
        cairo_identity_matrix(cairo);
        cairo_set_line_width(cairo,1);
        cairo_stroke(cairo);
      }

      if (!displayContents())
        {
          if (displayPlot)
            {
              const cairo::CairoSave cs(cairo);
              if (flipped)
                {
                  cairo_translate(cairo,width,height);
                  cairo_rotate(cairo,M_PI);  // rotate plot to keep it right way up.
                }
              // propagate plot type to underling ecolab::Plot
              auto& pt=const_cast<Plot*>(static_cast<const Plot*>(displayPlot.get()))->plotType;
              switch (displayPlot->plotType)
                {
                case PlotWidget::line: pt=Plot::line; break;
                case PlotWidget::bar:  pt=Plot::bar;  break;
                default: break;
                }
              displayPlot->Plot::draw(cairo, width, height);
            }
          else
            {
              cairo_scale(cairo,width/svgRenderer.width(),height/svgRenderer.height());
              cairo_rectangle(cairo,0, 0,svgRenderer.width(), svgRenderer.height());
              cairo_clip(cairo);
              svgRenderer.render(cairo);
            }
        }
    }

    drawEdgeVariables(cairo);


    // display text label
    if (!title.empty())
      {
        const cairo::CairoSave cs(cairo);
        cairo_scale(cairo, z, z);
        cairo_select_font_face
          (cairo, "sans-serif", CAIRO_FONT_SLANT_ITALIC, 
           CAIRO_FONT_WEIGHT_NORMAL);
        cairo_set_font_size(cairo,12);
              
        // extract the bounding box of the text
        cairo_text_extents_t bbox;
        cairo_text_extents(cairo,title.c_str(),&bbox);       
        const double w=0.5*bbox.width+2; 
        const double h=0.5*bbox.height+5;

        // if rotation is in 1st or 3rd quadrant, rotate as
        // normal, otherwise flip the text so it reads L->R
        if (flipped)
          cairo_rotate(cairo, M_PI);

        // prepare a background for the text, partially obscuring graphic
        const double transparency=displayContents()? 0.25: 1;

        // display text
        cairo_move_to(cairo, -w+1, h-12-0.5*(height)/z);
        cairo_set_source_rgba(cairo,0,0,0,transparency);
        cairo_show_text(cairo,title.c_str());
      }

    if (mouseFocus)
      {
        displayTooltip(cairo,tooltip());
        // Resize handles always visible on mousefocus. For ticket 92.
        drawResizeHandles(cairo);
      }

    cairo_rectangle(cairo,-0.5*width,-0.5*height,width,height);
    cairo_clip(cairo);
    if (selected)
      drawSelected(cairo);
    
  }

  void Group::draw1edge(const vector<VariablePtr>& vars, cairo_t* cairo, 
                        float x) const
  {
    float top=0, bottom=0;
    const double angle=rotation() * M_PI / 180.0;
    for (size_t i=0; i<vars.size(); ++i)
      {
        const Rotate r(rotation(),0,0);
        auto& v=vars[i];
        float y=0;
        auto z=v->zoomFactor();
        auto t=v->bb.top()*z, b=v->bb.bottom()*z;
        if (i>0) y = i%2? top-b: bottom-t;
        v->moveTo(r.x(x,y)+this->x(), r.y(x,y)+this->y());
        const cairo::CairoSave cs(cairo);
        cairo_translate(cairo,x,y);
        // cairo context is already rotated, so antirotate
        cairo_rotate(cairo,-angle);
        v->rotation(rotation()); 
        v->draw(cairo);
        if (i==0)
          {
            bottom=b;
            top=t;
          }
        else if (i%2)
          top-=v->height();
        else
          bottom+=v->height();
      }
  }

  void Group::drawEdgeVariables(cairo_t* cairo) const
  {
    float left, right; margins(left,right);    
    const cairo::CairoSave cs(cairo);
    const float z=zoomFactor();
    draw1edge(inVariables, cairo, -0.5*(iWidth()*z-left));
    draw1edge(outVariables, cairo, 0.5*(iWidth()*z-right));
  }

  namespace
  {
    // return the y position of the notch
    float notchY(const vector<VariablePtr>& vars)
    {
      if (vars.empty()) return 0;
      const float z=vars[0]->zoomFactor();
      float top=vars[0]->bb.top()*z, bottom=vars[0]->bb.top()*z;
      for (size_t i=0; i<vars.size(); ++i)
          {
            if (i%2)
              top-=vars[i]->height();
            else
              bottom+=vars[i]->height();
          }
      return vars.size()%2? top-vars.back()->bb.bottom()*z: bottom-vars.back()->bb.top()*z;
    }
  }
    
  // draw notches in the I/O region to indicate docking capability
  void Group::drawIORegion(cairo_t* cairo) const
  {
    const cairo::CairoSave cs(cairo);
    float left, right; 
    margins(left,right);
    const float z=zoomFactor();
    float y=notchY(inVariables), dy=topMargin*edgeScale();
    cairo_set_source_rgba(cairo,0,1,1,0.5);
    const float w=0.5*z*iWidth(), h=0.5*z*iHeight();
    
    cairo_move_to(cairo,-w,-h);
    // create notch in input region
    cairo_line_to(cairo,-w,y-dy);
    cairo_line_to(cairo,left-w-4*z,y-dy);
    cairo_line_to(cairo,left-w,y);
    cairo_line_to(cairo,left-w-4*z,y+dy);
    cairo_line_to(cairo,-w,y+dy);
    cairo_line_to(cairo,-w,h);
    cairo_line_to(cairo,left-w,h);
    cairo_line_to(cairo,left-w,-h);
    cairo_close_path(cairo);
    cairo_fill(cairo);

    y=notchY(outVariables);
    cairo_move_to(cairo,w,-h);
    // create notch in output region
    cairo_line_to(cairo,w,y-dy);
    cairo_line_to(cairo,w-right-2*z,y-dy);
    cairo_line_to(cairo,w-right+2*z,y);
    cairo_line_to(cairo,w-right-2*z,y+dy);
    cairo_line_to(cairo,w,y+dy);
    cairo_line_to(cairo,w,h);
    cairo_line_to(cairo,w-right,h);
    cairo_line_to(cairo,w-right,-h);
    cairo_close_path(cairo);
    cairo_fill(cairo);
    
    // draw top margin. for feature 88
    cairo_rectangle(cairo,-w,-h,2*w,-topMargin*z);
    cairo_fill(cairo);    
    
    // draw bottom margin. for feature 88
    cairo_rectangle(cairo,-w,h,2*w,topMargin*z);
    cairo_fill(cairo);    
  }


  void Group::margins(float& left, float& right) const
  {
    left=right=10;
    auto tmpMouseFocus=mouseFocus;
    mouseFocus=false; // disable mouseFocus for this calculation
    for (auto& i: inVariables)
      {
        assert(i->type()!=VariableType::undefined);
        i->bb.update(*i);
        if (i->width()>left) left=i->width();
      }
    for (auto& i: outVariables)
      {
        assert(i->type()!=VariableType::undefined);
        i->bb.update(*i);
        if (i->width()>right) right=i->width();
      }
    mouseFocus=tmpMouseFocus;
  }  

  float Group::rotFactor() const
  {
    float rotFactor;
    const float ac=abs(cos(rotation()*M_PI/180));
    static const float invSqrt2=1/sqrt(2);
    if (ac>=invSqrt2) 
      rotFactor=1.15/ac; //use |1/cos(angle)| as rotation factor
    else
      rotFactor=1.15/sqrt(1-ac*ac);//use |1/sin(angle)| as rotation factor
    return rotFactor;
  }

  ItemPtr Group::select(float x, float y) const
  {
    for (auto& v: inVariables)
      if (RenderVariable(*v).inImage(x,y)) 
        return v;
    for (auto& v: outVariables)
      if (RenderVariable(*v).inImage(x,y)) 
        return v;
    return nullptr;
  }

  void Group::normaliseGroupRefs(const shared_ptr<Group>& self)
  {
    for (auto& i: items)
        i->group=self;
    for (auto& g: groups)
      {
        g->group=self;
        g->normaliseGroupRefs(g);
      }
  }

  
  void Group::flipContents()
  {
    for (auto& i: items)
      {
        i->moveTo(x()-i->m_x,i->y());
        i->flip();
      }
    for (auto& i: groups)
      {
        i->moveTo(x()-i->m_x,i->y());
        i->flip();
      }
  }

  vector<string> Group::accessibleVars() const
{
  set<string> r;
  // first add local variables
  for (auto& i: items)
    if (auto v=i->variableCast())
      r.insert(v->name());
  // now add variables in outer scopes, ensuring they qualified
  auto g=this;
  for (g=g->group.lock().get(); g;  g=g->group.lock().get())
    for (auto& i: g->items)
      if (auto v=i->variableCast())
        {
          auto n=v->name();
          if (n[0]==':')
            r.insert(n);
          else
            r.insert(':'+n);
        }

  return vector<string>(r.begin(),r.end());
}

  void Group::gotoBookmark_b(const Bookmark& b)
  {
    moveTo(b.x, b.y);
    zoom(x(),y(),b.zoom/(relZoom*zoomFactor()));
    // TODO add canvas::gotoBookmark to avoid dependency inversion
    if (this==cminsky().canvas.model.get()) minsky().canvas.requestRedraw();
  }
  
  std::string Group::defaultExtension() const
  {
    if (findAny(&GroupItems::items, [](const ItemPtr& i){return dynamic_cast<Ravel*>(i.get());}))
      return ".rvl";
    return ".mky";
  }

  void Group::autoLayout()
  {
    const BusyCursor busy(minsky());
    layoutGroup(*this);
  }

  void Group::randomLayout()
  {
    const BusyCursor busy(minsky());
    randomizeLayout(*this);
  }

  vector<Summary> Group::summariseGodleys() const
  {
    vector<Summary> r;
    recursiveDo(&GroupItems::items, [&](const Items&,Items::const_iterator i) {
      if (auto g=dynamic_cast<GodleyIcon*>(i->get()))
        {
          auto summary=g->summarise();
          r.insert(r.end(),summary.begin(), summary.end());
        }
      return false;
    });
    return r;
  }

  void Group::renameAllInstances(const std::string& valueId, const std::string& newName)
    {
      // unqualified versions of the names
      auto p=valueId.find(':');
      string uqFromName=(p!=string::npos)? valueId.substr(p+1): valueId;
      string uqNewName = newName.substr(newName[0]==':'? 1: 0);
      set<GodleyIcon*> godleysToUpdate;
#ifndef NDEBUG
      auto numItems=this->numItems();
#endif
      recursiveDo
          (&GroupItems::items, [&](Items&,Items::iterator i)
           {
             if (auto v=(*i)->variableCast())
               if (v->valueId()==valueId)
                 {                       
                   auto varScope=scope(v->group.lock(), valueId);
                   if (auto g=dynamic_cast<GodleyIcon*>(v->controller.lock().get()))
                     {
                       if (varScope==g->group.lock() ||
                           (!varScope && g->group.lock()==cminsky().model)) // fix local variables
                         g->table.rename(uqFromName, uqNewName);
                       
                       // scope of an external ref in the Godley Table
                       auto externalVarScope=scope(g->group.lock(), ':'+uqNewName);
                       // if we didn't find it, perhaps the outerscope variable hasn't been changed
                       if (!externalVarScope)
                         externalVarScope=scope(g->group.lock(), ':'+uqFromName);

                       if (varScope==externalVarScope ||  (isGlobal(varScope) && isGlobal(externalVarScope)))
                         // fix external variable references
                         g->table.rename(':'+uqFromName, ':'+uqNewName);
                       // GodleyIcon::update invalidates the iterator, so postpone update
                       godleysToUpdate.insert(g);
                     }
                   else
                     {
                       // ensure locality is preserved across the rename
                       v->name(varScope==v->group.lock()? uqNewName: (':'+uqNewName));
                       if (auto vv=v->vValue()) 
                         v->retype(vv->type()); // ensure correct type. Note this invalidates v.
                     }
                 }
             return false;
           });
        assert(this->numItems()==numItems);
        for (auto g: godleysToUpdate)
          {
            g->update();
            assert(this->numItems()==numItems);
          }
      minsky().requestReset();   // Updates model after variables rename. For ticket 1109.    
    }

}

CLASSDESC_ACCESS_EXPLICIT_INSTANTIATION(minsky::Group);
CLASSDESC_ACCESS_EXPLICIT_INSTANTIATION(minsky::ItemT<minsky::Group>);
CLASSDESC_ACCESS_EXPLICIT_INSTANTIATION(minsky::Bookmark);